Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address potential Persistent Settings Getters race. #3095

Merged
merged 1 commit into from
May 9, 2024
Merged

Address potential Persistent Settings Getters race. #3095

merged 1 commit into from
May 9, 2024

Commits on May 8, 2024

  1. Address potential Persistent Settings Getters race. 

    While Getters and SetterHelpers both use locks to prevent race
conditions, Setters do not. Given that Setters run SetterHelpers through
posted tasks, it is possible for Getters to run in-between Setters and
SetterHelpers causing a race condition. To resolve this, effectively add
Getters into the PostTask Queue by calling WaitForFence. Also refactor
GetValues calls so that they are run by Setters rather than Getters to
limit the number of deep copies made.

Now that Getters and Setters no longer race, massively clean up the
tests by removing the unwieldly and now unneeded closures.

b/305057554
    @briantting
    briantting committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6ad2dc3 View commit details
    Browse the repository at this point in the history