Address potential Persistent Settings Getters race. #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantting
force-pushed
the
main
branch
2 times, most recently
from
d0f8b71
to
6b68dc5
Compare
|
Current implementation of using the fence fails https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:cobalt/base/task_runner_util.cc;l=50 |
briantting
force-pushed
the
main
branch
5 times, most recently
from
25580e1
to
8300933
Compare
jellefoks
requested changes
May 1, 2024
|
@briantting, I took another look at |
I don't think we want the blocking argument at all, we don't want anything to wait on disk writes. That was a quirk that was added purely so we could run tests and should no longer be needed with this refactor. |
|
@briantting I've gotten rid of the |
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 6, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 6, 2024
Building off the work of @briantting: youtube#3095 b/305057554
While Getters and SetterHelpers both use locks to prevent race conditions, Setters do not. Given that Setters run SetterHelpers through posted tasks, it is possible for Getters to run in-between Setters and SetterHelpers causing a race condition. To resolve this, effectively add Getters into the PostTask Queue by calling WaitForFence. Also refactor GetValues calls so that they are run by Setters rather than Getters to limit the number of deep copies made. Now that Getters and Setters no longer race, massively clean up the tests by removing the unwieldly and now unneeded closures. b/305057554
jellefoks
approved these changes
May 9, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
May 10, 2024
While Getters and SetterHelpers both use locks to prevent race conditions, Setters do not. Given that Setters run SetterHelpers through posted tasks, it is possible for Getters to run in-between Setters and SetterHelpers causing a race condition. To resolve this, effectively add Getters into the PostTask Queue by calling WaitForFence. Also refactor GetValues calls so that they are run by Setters rather than Getters to limit the number of deep copies made. Now that Getters and Setters no longer race, massively clean up the tests by removing the unwieldly and now unneeded closures. b/305057554 (cherry picked from commit feba187)
briantting
added a commit
that referenced
this pull request
May 10, 2024
…ace. (#3213) Refer to the original PR: #3095 While Getters and SetterHelpers both use locks to prevent race conditions, Setters do not. Given that Setters run SetterHelpers through posted tasks, it is possible for Getters to run in-between Setters and SetterHelpers causing a race condition. To resolve this, effectively add Getters into the PostTask Queue by calling WaitForFence. Also refactor GetValues calls so that they are run by Setters rather than Getters to limit the number of deep copies made. Now that Getters and Setters no longer race, massively clean up the tests by removing the unwieldly and now unneeded closures. b/305057554 Co-authored-by: Brian Ting <[email protected]>
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 10, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 10, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 10, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 16, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 17, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 17, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 17, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 24, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 24, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
to aee-google/cobalt
that referenced
this pull request
May 24, 2024
Building off the work of @briantting: youtube#3095 b/305057554
aee-google
added a commit
that referenced
this pull request
May 24, 2024
Building off the work of @briantting: #3095 b/305057554
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Building off the work of @briantting: #3095 b/305057554 (cherry picked from commit aeaed9d)
kaidokert
pushed a commit
that referenced
this pull request
Jun 11, 2024
Refer to the original PR: #3173 Building off the work of @briantting: #3095 b/305057554 Co-authored-by: aee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Getters and SetterHelpers both use locks to prevent race
conditions, Setters do not. Given that Setters run SetterHelpers through
posted tasks, it is possible for Getters to run in-between Setters and
SetterHelpers causing a race condition. To resolve this, effectively add
Getters into the PostTask Queue by calling WaitForFence. Also refactor
GetValues calls so that they are run by Setters rather than Getters to
limit the number of deep copies made.
Now that Getters and Setters no longer race, massively clean up the
tests by removing the unwieldly and now unneeded closures.
b/305057554