Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized variable append_ in class constructors #2205

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

alexanderbobrovnik
Copy link
Collaborator

@alexanderbobrovnik alexanderbobrovnik commented Jan 12, 2024

b/219048469

Test-On-Device: true

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd0dbd8) 58.44% compared to head (223bf34) 58.46%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
+ Coverage   58.44%   58.46%   +0.02%     
==========================================
  Files        1901     1901              
  Lines       94607    94607              
==========================================
+ Hits        55290    55310      +20     
+ Misses      39317    39297      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

base/files/file.cc Outdated Show resolved Hide resolved
@TyHolc
Copy link
Contributor

TyHolc commented Jan 23, 2024

Rerunning the failed flows. For on-device tests it looks like some player_filter_tests on darwin-tvos/simulator/devel failed, but it doesn't seem related so I'll rerun those too.

@TyHolc
Copy link
Contributor

TyHolc commented Jan 24, 2024

Rerunning the failed flows. For on-device tests it looks like some player_filter_tests on darwin-tvos/simulator/devel failed, but it doesn't seem related so I'll rerun those too.

Rerunning those and they failed again. If you think it's unrelated, we should probably rebase this and try again. Otherwise can you take a look.

UPDATE: you can ignore the above message, the failure isn't related to this. Just make sure the failed checks below pass.

@alexanderbobrovnik
Copy link
Collaborator Author

Few checks are still failing after the rebase, seems unrelated to this change.

@TyHolc TyHolc merged commit 66c5e33 into youtube:main Jan 31, 2024
333 of 334 checks passed
@TyHolc TyHolc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 31, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 31, 2024
b/219048469

Test-On-Device: true
(cherry picked from commit 66c5e33)
kaidokert pushed a commit that referenced this pull request Feb 7, 2024
…structors (#2358)

Refer to the original PR: #2205

b/219048469

Test-On-Device: true

Co-authored-by: alexanderbobrovnik <[email protected]>
@alexanderbobrovnik alexanderbobrovnik deleted the b219048469 branch April 2, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants