-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized variable append_ in class constructors #2205
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
==========================================
+ Coverage 58.44% 58.46% +0.02%
==========================================
Files 1901 1901
Lines 94607 94607
==========================================
+ Hits 55290 55310 +20
+ Misses 39317 39297 -20 ☔ View full report in Codecov by Sentry. |
9922aee
to
7d8e80a
Compare
7d8e80a
to
71b556d
Compare
Rerunning the failed flows. For on-device tests it looks like some player_filter_tests on darwin-tvos/simulator/devel failed, but it doesn't seem related so I'll rerun those too. |
Rerunning those and they failed again. If you think it's unrelated, we should probably rebase this and try again. Otherwise can you take a look. UPDATE: you can ignore the above message, the failure isn't related to this. Just make sure the failed checks below pass. |
71b556d
to
6330d1f
Compare
Few checks are still failing after the rebase, seems unrelated to this change. |
6330d1f
to
6695ffa
Compare
b/219048469 Test-On-Device: true (cherry picked from commit 66c5e33)
…structors (#2358) Refer to the original PR: #2205 b/219048469 Test-On-Device: true Co-authored-by: alexanderbobrovnik <[email protected]>
b/219048469
Test-On-Device: true