Fix uninitialized variable append_ in class constructors.

b/219048469
youtube · Jan 25, 2024 · 6330d1f · 6330d1f
1 parent 79920bc
commit 6330d1f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/base/files/file.cc b/base/files/file.cc
@@ -64,7 +64,13 @@ File::File(File&& other)
       tracing_path_(other.tracing_path_),
       error_details_(other.error_details()),
       created_(other.created()),
-      async_(other.async_) {}
+      async_(other.async_)
+#if defined(STARBOARD)
+      ,
+      append_(other.append_)
+#endif
+{
+}
 
 File::~File() {
   // Go through the AssertIOAllowed logic.
@@ -78,6 +84,9 @@ File& File::operator=(File&& other) {
   error_details_ = other.error_details();
   created_ = other.created();
   async_ = other.async_;
+#if defined(STARBOARD)
+  append_ = other.append_;
+#endif
   return *this;
 }
 

diff --git a/base/files/file.h b/base/files/file.h
@@ -380,7 +380,7 @@ class BASE_EXPORT File {
   bool async_;
 
 #if defined(STARBOARD)
-  bool append_;
+  bool append_ = false;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(File);