Set ldflags at top of modular config #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbournou
approved these changes
Dec 15, 2023
auto-merge was automatically disabled
December 15, 2023 23:16
Pull Request is not mergeable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 58.55% 58.53% -0.03%
==========================================
Files 1914 1914
Lines 94432 94432
==========================================
- Hits 55299 55273 -26
- Misses 39133 39159 +26 ☔ View full report in Codecov by Sentry. |
This avoids the possiblity to overwrite ldflags, as that is explicitly done with a variable being set to the empty list. b/302733082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the possiblity to overwrite ldflags, as that is explicitly done with a variable being set to the empty list.
b/302733082