Skip to content

Commit

Permalink
Set ldflags at top of modular config
Browse files Browse the repository at this point in the history
This avoids the possiblity to overwrite ldflags, as that is
explicitly done with a variable being set to the empty list.

b/302733082
  • Loading branch information
andrewsavage1 committed Dec 15, 2023
1 parent 4b57183 commit ffe9fa2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions starboard/build/config/modular/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

config("modular") {
ldflags = []
cflags = [
"-ffunction-sections",
"-fdata-sections",
Expand Down Expand Up @@ -171,8 +172,6 @@ config("modular") {
defines += [ "THREAD_SANITIZER" ]
}

ldflags = []

# Wrap underlying POSIX implementations to be cross-compatible with
# musl-based types that are used in modular builds. Evergreen builds use
# a different map-based wrapping of these POSIX APIs.
Expand Down

0 comments on commit ffe9fa2

Please sign in to comment.