Add NPLB tests for cast codecs. #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
+ Coverage 58.88% 59.02% +0.14%
==========================================
Files 1811 1813 +2
Lines 87503 87791 +288
==========================================
+ Hits 51523 51818 +295
+ Misses 35980 35973 -7 ☔ View full report in Codecov by Sentry. |
antoniori-eng
commented
Jan 9, 2024
xiaomings
reviewed
Jan 10, 2024
kaidokert
reviewed
Mar 16, 2024
jasonzhangxx
approved these changes
Mar 19, 2024
|
Thanks for the reviews! I'll sync to HEAD and re-run the tests before submitting. |
Note: this does not add a check for a MIME type corresponding to HEVC, since that codec isn't included in the list of supported MIME types in the default starboard impl. A test can be added in a follow-up CL, if HEVC is added to the supported MIME types in //starboard/shared/starboard/media/codec_util.cc. Bug: b/270621457 Test: To run all the SbPlayer NPLB tests related to writing samples, I ran out/linux-x64x11_cast_devel/nplb_loader --gtest_filter=SbPlayerWriteSampleTests*
Bug: b/270621457
This way, existing tests shouldn't be affected by this change. Bug: b/270621457 Change-Id: If0f1a0a23dff85e6669d50e99df3868f228f2021
Bug: b/270621457 Change-Id: Ie5e95903e7a00d2a752b751588cb928353a14f64
Bug: b/270621457 Change-Id: I5633f2a045a6b06429984ecec14ddf46b9d6c9d9
In starboard/nplb/player_test_util.cc there are already calls to SbMediaCanPlayMimeAndKeySystem to verify that the given codec can be played, so we don't need special handling for the cast-specific codecs. This commit also removes the changes in media_can_play_mime_and_key_system_test.cc. Those tests will be added into the cast contrib directory in a separate PR. Bug: b/270621457 Change-Id: Ia6d0e367e845f3468dca910c2b1e550e7072e9ed
Bug: b/270621457 Change-Id: Ice0ee8c5c4fd359335a4554569b5843b8dc2a652
Bug: b/270621457 Change-Id: I5d54c5a5b2679eff6fc53dd4c1f0e6c2e3860597
These files have been uploaded to GCS, and are downloaded by the script that sets up the NPLB test data. Bug: b/270621457 Change-Id: I54e6fe0cddba0c8212eb155ea3cc5771bf7c957a
Bug: b/27062145 Change-Id: I45a55b58b7fb50f5741c75b9fe88b16e33ac2c5b
MP3, FLAC, and PCM audio codecs were added in SB version 14. We shouldn't read dmp files with these codecs in earlier versions of Starboard. Bug: b/270621457 Change-Id: I38407058764ebf97817bc2fcac94b44de1ce9f1e
These no longer seem necessary; SbPlayerWriteSampleTests* tests pass without the changes to ConvertDurationToAudioBufferCount. Change-Id: I468755257d5c1cb2ff38fbb300f3724de4617697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds .dmp files that cover the additional codecs that cast uses.
Bug: b/270621457
Test:
To run all the SbPlayer NPLB tests related to writing samples, I ran out/linux-x64x11_cast_devel/nplb_loader --gtest_filter=SbPlayerWriteSampleTests*
Test-On-Device: true