Add SB_API_VERSION checks for new codecs.

Bug: b/270621457
youtube · Dec 15, 2023 · 95757cd · 95757cd
1 parent 950a044
commit 95757cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/starboard/nplb/media_can_play_mime_and_key_system_test.cc b/starboard/nplb/media_can_play_mime_and_key_system_test.cc
@@ -962,6 +962,7 @@ TEST(SbMediaCanPlayMimeAndKeySystem, FLAKY_ValidatePerformance) {
 
 #if defined(USE_CONTRIB_CAST)
 TEST(SbMediaCanPlayMimeAndKeySystem, CastCodecsAreSupported) {
+#if SB_API_VERSION >= 14
   // FLAC
   EXPECT_EQ(SbMediaCanPlayMimeAndKeySystem("audio/ogg; codecs=\"flac\";", ""),
             kSbMediaSupportTypeProbably);
@@ -973,6 +974,7 @@ TEST(SbMediaCanPlayMimeAndKeySystem, CastCodecsAreSupported) {
   // PCM
   EXPECT_EQ(SbMediaCanPlayMimeAndKeySystem("audio/wav; codecs=\"1\";", ""),
             kSbMediaSupportTypeProbably);
+#endif  // SB_API_VERSION >= 14
 
   // Vorbis
   EXPECT_EQ(

diff --git a/starboard/shared/starboard/player/video_dmp_reader.cc b/starboard/shared/starboard/player/video_dmp_reader.cc
@@ -154,6 +154,7 @@ std::string VideoDmpReader::audio_mime_type() const {
     case kSbMediaAudioCodecVorbis:
       ss << "audio/webm; codecs=\"vorbis\";";
       break;
+#if SB_API_VERSION >= 14
     case kSbMediaAudioCodecMp3:
       ss << "audio/mpeg";
       break;
@@ -163,6 +164,7 @@ std::string VideoDmpReader::audio_mime_type() const {
     case kSbMediaAudioCodecPcm:
       ss << "audio/wav; codecs=\"1\";";
       break;
+#endif  // SB_API_VERSION >= 14
     default:
       SB_NOTREACHED() << "Unsupported audio codec: " << dmp_info_.audio_codec;
   }