Add CHECK for cobalt::loader::FetcherCache #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
reviewed
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
=======================================
Coverage 57.67% 57.67%
=======================================
Files 1909 1909
Lines 95133 95134 +1
=======================================
+ Hits 54866 54867 +1
Misses 40267 40267 ☔ View full report in Codecov by Sentry. |
Add more CHECK to identify the root cause of the crash. b/270993319
borongc
force-pushed
the
fetcher_cache_log
branch
from
2547c77
to
9def070
Compare
xiaomings
approved these changes
Nov 15, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
(cherry picked from commit 1214fb7)
|
@borongc Next time you use squash and merge, can you make sure the bug id is in the squashed commit message? It looks like it was removed before merging https://github.com/youtube/cobalt/actions/runs/6881357377 |
|
@oxve Will check next time. Would this be fixable for this merge? |
borongc
added a commit
that referenced
this pull request
Nov 29, 2023
(cherry picked from commit 1214fb7)
borongc
added a commit
that referenced
this pull request
Nov 29, 2023
Refer to the original PR: #1983 Add more CHECK to identify the root cause of the crash. b/270993319 Co-authored-by: Bo-Rong Chen <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more CHECK to identify the root cause of the crash.
b/270993319