-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for cobalt::loader::FetcherCache #1832
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 59.74% 57.67% -2.08%
==========================================
Files 1825 1910 +85
Lines 88124 95142 +7018
==========================================
+ Hits 52652 54873 +2221
- Misses 35472 40269 +4797 ☔ View full report in Codecov by Sentry. |
e1abce0
to
89c7442
Compare
89c7442
to
530f990
Compare
530f990
to
93a31a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! a few minor comments.
93a31a8
to
fc2709a
Compare
78d2212
to
7bdf2dd
Compare
Test FetcherCache with corner cases, and try to catch crash issue. b/270993319
7bdf2dd
to
03ce1c5
Compare
Test FetcherCache with corner cases, and try to catch crash issue. b/270993319 (cherry picked from commit 89a8945)
…#2935) Refer to the original PR: #1832 Test FetcherCache with corner cases, and try to catch crash issue. b/270993319 Co-authored-by: Bo-Rong Chen <[email protected]>
Test FetcherCache with corner cases, and try to catch crash issue.
b/270993319