Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for cobalt::loader::FetcherCache #1832

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Oct 22, 2023

Test FetcherCache with corner cases, and try to catch crash issue.

b/270993319

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.67%. Comparing base (52dee1f) to head (93a31a8).
Report is 37 commits behind head on main.

❗ Current head 93a31a8 differs from pull request most recent head 03ce1c5. Consider uploading reports for the commit 03ce1c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   59.74%   57.67%   -2.08%     
==========================================
  Files        1825     1910      +85     
  Lines       88124    95142    +7018     
==========================================
+ Hits        52652    54873    +2221     
- Misses      35472    40269    +4797     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
@borongc borongc force-pushed the fetcher_cache_test branch 7 times, most recently from e1abce0 to 89c7442 Compare October 26, 2023 17:58
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! a few minor comments.

cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
cobalt/loader/fetcher_cache_test.cc Outdated Show resolved Hide resolved
@borongc borongc force-pushed the fetcher_cache_test branch 3 times, most recently from 78d2212 to 7bdf2dd Compare April 12, 2024 22:00
Test FetcherCache with corner cases, and try to catch crash issue.

b/270993319
@borongc borongc merged commit 89a8945 into youtube:main Apr 14, 2024
382 of 383 checks passed
@borongc borongc deleted the fetcher_cache_test branch April 14, 2024 18:53
@borongc borongc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Apr 14, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Apr 14, 2024
Test FetcherCache with corner cases, and try to catch crash issue.

b/270993319

(cherry picked from commit 89a8945)
borongc added a commit that referenced this pull request Apr 15, 2024
…#2935)

Refer to the original PR: #1832

Test FetcherCache with corner cases, and try to catch crash issue.

b/270993319

Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch on_device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants