-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): bump risc0 and sp1 versions #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small comments, everything worked well on my macos and linux.
JuArce
requested changes
Oct 25, 2024
JuArce
changed the title
1205 operator verifier update
feat(operator): bump risc0 and sp1 versions
Oct 25, 2024
JuArce
approved these changes
Oct 25, 2024
uri-99
approved these changes
Oct 25, 2024
1 task
PatStiles
added a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Marcos Nicolau <[email protected]>
avilagaston9
pushed a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Marcos Nicolau <[email protected]>
samoht9277
pushed a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Marcos Nicolau <[email protected]>
PatStiles
added a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Marcos Nicolau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SP1 and Risc0 verifier versions
closes #1205
This PR:
risc0
andsp1
verifier versions of operators.To Test:
Verify network bindings works on a local network:
make test_risc_zero_go_bindings_macos
make test_sp1_go_bindings_macos
make batcher_send_risc0_task
make batcher_send_sp1_task
Verify Retro Compatiblility of Operator Verifiers:
To verify operator retro-compatibility we deploy the rest of infrastructure of Aligned and boot the retro-compatible operator. This tests that network retro-compatible operator can verify SP1/Risc0 proofs from both verifier versions.
Note:
Commands suffixed with
_old
indicate the deprecated version of the SP1/Risc0 verifier that is currently running ontestnet
To test this have two repos of aligned_layer one set to
testnet
and one to1205-bump-sp1-and-risc0-version
.In
testnet
repo:In
1205-operator-verifier-update
repo:testnet
repo.Observe the
Risc0 proof verification failed.
andSP1 proof verification failed.
logs are emitted and the operator successfully verifying the proofs from the old SP1/Risc0 verifiers. If you send a proof from the latest version of SP1/Risc0 you should notice its verification fails in the batcher.1205-operator-verifier-update
repo.testnet
repo, kill the batcher.1205-operator-verifier-update
and start the batcher within the repo.1205-operator-verifier-update
repo.Observe the operator successfully verifying the proofs from the new SP1/Risc0 verifiers. If you send a proof from the older version of SP1/Risc0 you should notice its verification fails in the batcher.
Type of change
Checklist