-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batcher): Update SP1 and Risc0 version in batcher, examples, and docs #1329
base: testnet
Are you sure you want to change the base?
Conversation
Co-authored-by: Marcos Nicolau <[email protected]>
19fe6b6
to
cc51dc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's approved, but don't merge until operators upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cases tested in stage:
Operator version: v0.10.2
- Send old proofs with the old batcher: It is the previous version, and it works. The operator logs that it is using old version of the prover ✅
- Send new proofs with the old batcher: The batcher rejects the proofs ✅
- Send new proofs with the new batcher. The operator uses the new version of the provers ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected on Linux and macos!
Updates on this? |
Still waiting , aprox 24hs and we eject unupgraded operators. |
Update Batcher SP1 and Risc0 version
Description
Complements #1324
Updates the SP1 and Risc0 version in the:
Renames the test files for SP1 and Risc0 by changing the respective suffix to point towards the correct version ("" indicates removal of the suffix):
"_new" -> ""
"" -> "-> old
NOTE: Removal of the old verifier ffi bindings will occur in a third pr.
Type of change