-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define remaining required OpenType tables #351
Conversation
It might be time to make an issue for "sequences of unspecified length", with the glyph names example and also the |
I did have #310 open which might do part of what we need, but I wasn't entirely happy with how I implemented the binary parser portion of it. Haven't got back to it yet. |
I opened #352 for this. |
@@ -1314,8 +1489,8 @@ let table_directory = fun (file_start : Pos) => { | |||
maxp.num_glyphs, | |||
}, | |||
name <- required_table "name" name_table, | |||
os2 <- required_table "OS/2" unknown_table, | |||
post <- required_table "post" unknown_table, | |||
os2 <- required_table_with_len "OS/2" os2_table, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brendanzab I rebased on main
. I added this new function because OS/2
needs access to the table length. Not sure if this is the best way or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, yeah I think this is ok for now! 👍
This adds:
OS/2
post
name
table.post
version 2 (embedded Pascal string glyph names) does not currently parse the names. I think this would be possible if there was a way to get the maximum (numeric) value from an array. That maximum value is the number of glyph names to read, which would allow something likeAlso is there a better way to handle the layering of versions in
OS/2
?