Implement dependencies on required font tables in OpenType format #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a fun idea to try to use more understnable names, but this makes it a bit easier to keep track of the names.
brendanzab
changed the title
mikeday
reviewed
Apr 29, 2022
|
Very exciting stuff! |
|
All those new built-ins look like they will be super useful! |
|
I might go ahead and merge this if folks are cool with it! Unless you want to merge #351 first? |
|
Fine with me, merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for dependencies between the required font tables in OpenType. I still need to figure out how to allow for dependencies on optional font tables, but I think it’s nice to make progress on this!
To do this I added the following builtins to Fathom:
Option : Type -> Typesome : fun (A : Type) -> A -> Option Anone : fun (A : Type) -> Option Afold : fun (A : Type) (B : Type) -> B -> (A -> B) -> Option A -> Barray8_find : fun (len : U8) (A : Type) -> (A -> Bool) -> Array8 len A -> Option Aarray16_find : fun (len : U16) (A : Type) -> (A -> Bool) -> Array16 len A -> Option Aarray32_find : fun (len : U32) (A : Type) -> (A -> Bool) -> Array32 len A -> Option Aarray64_find : fun (len : U64) (A : Type) -> (A -> Bool) -> Array64 len A -> Option Aunwrap : fun (A : Type) -> Option A -> Format(whereRepr (unwrap A option_a) = A)