Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make E_TRY_AGAIN error retriable #2151

Closed
wants to merge 1 commit into from
Closed

Make E_TRY_AGAIN error retriable #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cloud/storage/core/libs/common/error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ EErrorKind GetErrorKind(const NProto::TError& e)
switch (code) {
case E_REJECTED:
case E_TIMEOUT:
case E_TRY_AGAIN:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужны аналогичные правки во всех наших sdk (go, python)

Copy link
Collaborator

@SvartMetal SvartMetal Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

хотя в blockstore оно уже ретраится https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/public/sdk/python/client/error.py#L61, https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/public/sdk/go/client/error.go#L41

Copy link
Collaborator

@SvartMetal SvartMetal Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а в filestore нет такого кода в sdk, хотя в коде он посылается

например https://github.com/ydb-platform/nbs/blob/main/cloud/filestore/libs/storage/tablet/tablet_actor_compaction.cpp#L468

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в файлсторе этот код в ответ на внутренние запросы посылается, так что это не страшно

но для порядка стоит добавить в sdk, да

case E_BS_OUT_OF_SPACE:
case E_FS_OUT_OF_SPACE:
case E_BS_THROTTLED:
Expand Down
Loading