Make E_TRY_AGAIN error retriable #2151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvartMetal
reviewed
Sep 27, 2024
| @@ -51,6 +51,7 @@ EErrorKind GetErrorKind(const NProto::TError& e) | |||
| switch (code) { | |||
| case E_REJECTED: | |||
| case E_TIMEOUT: | |||
| case E_TRY_AGAIN: | |||
There was a problem hiding this comment.
нужны аналогичные правки во всех наших sdk (go, python)
There was a problem hiding this comment.
There was a problem hiding this comment.
а в filestore нет такого кода в sdk, хотя в коде он посылается
There was a problem hiding this comment.
в файлсторе этот код в ответ на внутренние запросы посылается, так что это не страшно
но для порядка стоит добавить в sdk, да
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Кажется ошибка E_TRY_AGAIN должна быть ретрабельной, а не EErrorKind::ErrorFatal как сейчас