Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NBS] Add the ability to enable a buffer copying for write requests before sending them to replicas #2421

Open
WilyTiger opened this issue Nov 5, 2024 · 0 comments
Open

[NBS] Add the ability to enable a buffer copying for write requests before sending them to replicas #2421

WilyTiger opened this issue Nov 5, 2024 · 0 comments
Assignees
@qkrorlqr
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR

Comments

@WilyTiger
Copy link
Collaborator

WilyTiger commented Nov 5, 2024 •
edited
Loading

Some users may modify the data buffer after a write request is sent, which can lead to inconsistent data across replicas. We can easily reproduce it with this tool https://github.com/ydb-platform/nbs/tree/main/cloud/blockstore/tools/testing/bad-guest

In this issue we want to add a per-disk feature flag for these clients, and implement a mechanism to copy the data buffer on our side before sending requests to replicas
@WilyTiger WilyTiger added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Nov 5, 2024
@WilyTiger WilyTiger changed the title Add the ability to enable a copy buffer for write requests before sending them to replicas [NBS] Add the ability to enable a copy buffer for write requests before sending them to replicas Nov 5, 2024
@WilyTiger WilyTiger changed the title [NBS] Add the ability to enable a copy buffer for write requests before sending them to replicas [NBS] Add the ability to enable a buffer copying for write requests before sending them to replicas Nov 5, 2024
@qkrorlqr qkrorlqr self-assigned this Nov 5, 2024
This was referenced Nov 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qkrorlqr qkrorlqr

Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qkrorlqr @WilyTiger