issue-2421: safer code + extra ut for use-intermediate-write-buffer volume tag #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrorlqr
added
blockstore
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-release-asan: all tests PASSED for commit bd3e21f.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit bd3e21f.
|
… tag - making the intentions a bit more clear
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-release-asan: all tests PASSED for commit d8760df.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d8760df.
|
…l safer, added some other safety checks and comments
qkrorlqr
changed the title
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-release-asan: all tests PASSED for commit c9180fb.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c9180fb.
|
drbasic
approved these changes
Nov 10, 2024
WilyTiger
approved these changes
Nov 11, 2024
qkrorlqr
added a commit
that referenced
this pull request
Nov 11, 2024
…olume tag (#2452) * issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag * issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag - making the intentions a bit more clear * issue-2421: made local->remote request conversion in partition_nonrepl safer, added some other safety checks and comments
qkrorlqr
added a commit
that referenced
this pull request
Nov 12, 2024
…r tag implementation; filestore: compaction tuning, cli tuning, shard autocreation bits (#2470) * moved unstable output from test canondata to test stderr (#2416) * issue-2421: added volume tag which forces user write buffer copying to our internal buffers to avoid writing different data to different replicas of the same volume in case of concurrent buffer modifications by the client (#2431) * issue-1932: automatic filesystem shard configuration upon filesystem creation (#2415) * issue-1932: autosharding params * issue-1932: automatic filesystem shard creation+configuration upon filesystem creation * issue-1932: properly limiting max shard count * issue-1932: fixed signed/unsigned comparison * issue-1932: fixed use-after-free in ut (#2441) * filestore-client: outputting progress in findgarbage; properly processing ForcedOperationStatus errors in forcedcompaction (#2442) * issue-2137: if all ranges in CompactionMap have the 'compacted' flag then GetTop{Compaction,Garbage}Score should return zero (in order not to trigger dud Compaction iterations all the time) (#2455) * issue-2421: safer code + extra ut for use-intermediate-write-buffer volume tag (#2452) * issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag * issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag - making the intentions a bit more clear * issue-2421: made local->remote request conversion in partition_nonrepl safer, added some other safety checks and comments * fixed build after incorrect merge 5887fb6 * fixed build 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added ut is useful but unfortunately it doesn't reproduce the problem it was intended to reproduce due to TString's COW. But I made the code safer just in case.
#2421