Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-2421: added volume tag which forces user write buffer copying to our internal buffers to avoid writing different data to different replicas of the same volume in case of concurrent buffer modifications by the client #2431

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

qkrorlqr
Copy link
Collaborator

@qkrorlqr qkrorlqr commented Nov 6, 2024

Use case:

  1. scrubbing detects data inconsistency between the replicas
  2. we verify that this inconsistency wasn't caused by our own bugs
  3. we set this tag for the affected volume - performance will slightly decrease but there will be no new inconsistencies after that

#2421

…o our internal buffers to avoid writing different data to different replicas of the same volume in case of concurrent buffer modifications by the client
@qkrorlqr qkrorlqr added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit fa0c1bb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3479 3479 0 0 0 0

@qkrorlqr qkrorlqr merged commit ed3bbbb into main Nov 6, 2024
11 of 22 checks passed
@qkrorlqr qkrorlqr deleted the users/qkrorlqr/issue-2421-2 branch November 6, 2024 17:08
qkrorlqr added a commit that referenced this pull request Nov 11, 2024
…o our internal buffers to avoid writing different data to different replicas of the same volume in case of concurrent buffer modifications by the client (#2431)
qkrorlqr added a commit that referenced this pull request Nov 12, 2024
…r tag implementation; filestore: compaction tuning, cli tuning, shard autocreation bits (#2470)

* moved unstable output from test canondata to test stderr (#2416)

* issue-2421: added volume tag which forces user write buffer copying to our internal buffers to avoid writing different data to different replicas of the same volume in case of concurrent buffer modifications by the client (#2431)

* issue-1932: automatic filesystem shard configuration upon filesystem creation (#2415)

* issue-1932: autosharding params

* issue-1932: automatic filesystem shard creation+configuration upon filesystem creation

* issue-1932: properly limiting max shard count

* issue-1932: fixed signed/unsigned comparison

* issue-1932: fixed use-after-free in ut (#2441)

* filestore-client: outputting progress in findgarbage; properly processing ForcedOperationStatus errors in forcedcompaction (#2442)

* issue-2137: if all ranges in CompactionMap have the 'compacted' flag then GetTop{Compaction,Garbage}Score should return zero (in order not to trigger dud Compaction iterations all the time) (#2455)

* issue-2421: safer code + extra ut for use-intermediate-write-buffer volume tag (#2452)

* issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag

* issue-2421: nonrepl disk ut with use-intermediate-write-buffer volume tag - making the intentions a bit more clear

* issue-2421: made local->remote request conversion in partition_nonrepl safer, added some other safety checks and comments

* fixed build after incorrect merge 5887fb6

* fixed build 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants