Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docker compose #295

wants to merge 1 commit into from

Conversation

aronbierbaum
Copy link
Contributor

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@aronbierbaum aronbierbaum mentioned this pull request Mar 2, 2024
Closed
5 tasks
@coveralls
Copy link

Coverage Status

coverage: 85.943%. remained the same
when pulling 5a71d3b on aronbierbaum:docker_compose
into ac9442a on xzkostyan:master.

xzkostyan
xzkostyan reviewed Aug 6, 2024
View reviewed changes
docs/development.rst

Create ``clickhouse-client`` script on your host machine:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was dedicated for running tests on machine without clickhouse-client installed.

is it still possible to run tests on such machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzkostyan xzkostyan xzkostyan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aronbierbaum @coveralls @xzkostyan