Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action improvement #273

Closed
wants to merge 2 commits into from
Closed

Conversation

Net-Mist
Copy link
Contributor

Hello !

I would like to propose some change to the github actions to use the services capabilities to start the clickhouse server instead of hacking the setup.cfg and the host network. I also updated the doc to reflect this change.

What do you think ?

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@coveralls
Copy link

Coverage Status

coverage: 85.756%. remained the same when pulling d028c13 on Net-Mist:github_action into b19a31f on xzkostyan:master.

@xzkostyan
Copy link
Owner

I don't see docker-compose.yml in the diff.

If these changes will allow to run tests against ClickHouse:

  • installed on local machine. I run tests on local machine without docker for more efficient debugging and speed.
  • in docker on local machine;
  • in CI/CD.

I'm ok with it.

@aronbierbaum
Copy link
Contributor

@Net-Mist @xzkostyan I split this into two pull requests, added a compose.yaml file and can make sure everything is passing.

@xzkostyan
Copy link
Owner

Closing this PR for two PRs by @aronbierbaum above.

@xzkostyan xzkostyan closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants