Sa 2.0

[PedroAquilino]

• fixes Support for Sqlalchemy 2.0? #242

• fixes #

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• Add or update relevant docs, in the docs folder and in code.
• Ensure PR doesn't contain untouched code reformatting: spaces, etc.
• Run flake8 and fix issues.
• Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

[coveralls]

coverage: 85.542% (-0.2%) from 85.736% when pulling fc2f432 on usizy:sa-2.0 into 9545a17 on xzkostyan:master.

[Net-Mist]

Hello,
thanks a lot for your work, we were looking to move to sqlalchemy 2 for a long time :)

I tested your code, and have a bug. When importing import clickhouse_sqlalchemy.types I get

ImportError: cannot import name '_bind_or_error' from 'sqlalchemy.sql.base' ([...]/python3.11/site-packages/sqlalchemy/sql/base.py)

Indeed, your code is still using _bind_or_error whereas it doesn't exist anymore in sqlalchemy 2. FYI, in v1.4, the function has a deprecated warning: "The bind argument for schema methods that invoke SQL against an engine or connection will be required in SQLAlchemy 2.0."

[PedroAquilino]

Thanks @Net-Mist I check how to remove the reference to _bind_or_error

[Net-Mist]

Hello !

I found another issue. In file clickhouse_sqlalchemy/ext/clauses.py, in the init of Lambda class, we need to replace util.callable to callable. Indeed sqlalchemy >= 2.0 doesn't provide this function anymore as it is now in python since 3.2

[PedroAquilino]

I have changed the call to util.callable to the builtin callable

[m-alhajji]

Hi. Is there anything blocking this at the moment? Has people migrated to a different tool? Can I be of any help?

[xzkostyan]

Now tests are not green even after fixing lint errors: https://github.com/xzkostyan/clickhouse-sqlalchemy/actions/runs/6266313792/job/17017005243

[xzkostyan]

Thank you. SQLAlchemy 2.0 support was released in 0.3.0.