Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy 2.0 #268

Merged
merged 21 commits into from
Oct 29, 2023
Merged

SQLAlchemy 2.0 #268

merged 21 commits into from
Oct 29, 2023

Conversation

Net-Mist
Copy link
Contributor

@Net-Mist Net-Mist commented Oct 23, 2023

Hello,

This PR make this code compatible with SQLAlchemy 2 and all unit-tests should be passing (they are on my fork).
I started from #256.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@coveralls
Copy link

coveralls commented Oct 23, 2023

Coverage Status

coverage: 85.756% (-0.2%) from 85.952% when pulling 9a14437 on Net-Mist:sa-2.0 into e16d482 on xzkostyan:master.

@xzkostyan
Copy link
Owner

Thanks.

I'll make 0.3.0 release on next week.

@xzkostyan xzkostyan merged commit b19a31f into xzkostyan:master Oct 29, 2023
37 of 56 checks passed
@xzkostyan
Copy link
Owner

Version 0.3.0 with SQLAlchemy 2.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to SQLAlchemy 2.0
6 participants