#336: Create show-if and hide-if macro #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* Move userlist and grouplist displayer in internal package so it can be reused by multiple macros * Use UserList and GroupList type for show-if and hide-if macro parameter to have a nice UI to edit macro
* Fix check from groups
trrenty
requested changes
Oct 2, 2024
...os-api/src/main/java/com/xwiki/macros/showhideif/internal/macro/AbstractShowHideIfMacro.java
Show resolved
Hide resolved
...os-api/src/main/java/com/xwiki/macros/showhideif/internal/macro/AbstractShowHideIfMacro.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/HideIfMacro.java
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/HideIfMacro.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/MacroParameter.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/MacroParameter.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/MacroParameter.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/MacroParameter.java
Outdated
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/ShowIfMacro.java
Show resolved
Hide resolved
xwiki-pro-macros-api/src/main/java/com/xwiki/macros/showhideif/macro/ShowIfMacro.java
Outdated
Show resolved
Hide resolved
raphj
reviewed
Oct 3, 2024
...os-api/src/main/java/com/xwiki/macros/showhideif/internal/macro/AbstractShowHideIfMacro.java
Show resolved
Hide resolved
…/macro/HideIfMacro.java Co-authored-by: Teo Caras <[email protected]>
…/macro/MacroParameter.java Co-authored-by: Teo Caras <[email protected]>
* Fix requested changes from PR xwikisas#337
trrenty
reviewed
Oct 7, 2024
...os-api/src/main/java/com/xwiki/macros/showhideif/internal/macro/AbstractShowHideIfMacro.java
Outdated
Show resolved
Hide resolved
trrenty
approved these changes
Oct 7, 2024
* Fix since tag * Rename parameters for mor consistency
|
thanks @trrenty for the review. Note I don't have the merge right so I leave you to merge it. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement show-if and hide-if macro
cf: #336