Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migration of show-if/hide-if macro #195

Closed
Josue-T opened this issue Sep 12, 2024 · 0 comments
Closed

Fix migration of show-if/hide-if macro #195

Josue-T opened this issue Sep 12, 2024 · 0 comments
Assignees
@Josue-T
Milestone
1.26.0

Comments

@Josue-T
Copy link
Contributor

Josue-T commented Sep 12, 2024

Related to xwikisas/xwiki-pro-macros#337

This is to handle correctly all parameter of this macro.

Note specialUsername and groupIds parameters was renamed and groupIds value is not converted correctly.
Josue-T added a commit to Josue-T/application-confluence-migrator-pro that referenced this issue Sep 12, 2024
@Josue-T
xwikisas#195: Fix migration of show-if/hide-if macro
05aa2c9 
* Implement migration of show-if and hide-if macro
@Josue-T Josue-T mentioned this issue Sep 12, 2024
Merged
Josue-T added a commit to Josue-T/application-confluence-migrator-pro that referenced this issue Oct 7, 2024
@Josue-T
xwikisas#195: Fix migration of show-if/hide-if macro
929b6ed 
* Remove optional return from confluence converter
Josue-T added a commit to Josue-T/application-confluence-migrator-pro that referenced this issue Oct 10, 2024
@Josue-T
xwikisas#195: Fix migration of show-if/hide-if macro
2ef616b 
* Implement migration of show-if and hide-if macro
Josue-T added a commit to Josue-T/application-confluence-migrator-pro that referenced this issue Oct 10, 2024
@Josue-T
xwikisas#195: Fix migration of show-if/hide-if macro
e6989bc 
* Remove optional return from confluence converter
Josue-T added a commit to Josue-T/application-confluence-migrator-pro that referenced this issue Oct 10, 2024
@Josue-T
xwikisas#195: Fix migration of show-if/hide-if macro
baeffb0 
* Remove empty class and use @component(hints = {...}) to apply the same class on multiple macro
@Josue-T Josue-T self-assigned this Oct 14, 2024
Josue-T added a commit that referenced this issue Oct 14, 2024
@Josue-T
#195: Fix migration of show-if/hide-if macro (#196)
72a9cec 
* Implement migration of show-if and hide-if macro
* Remove empty class and use @component(hints = {...}) to apply the same class on multiple macro
* Update since version

---------

Co-authored-by: Josué Tille <[email protected]>
@Josue-T Josue-T closed this as completed Oct 14, 2024
@raphj raphj added this to the 1.26.0 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josue-T Josue-T

Labels
None yet
Projects
Pro Apps Roadmap October - November 2024
Status: Done
Milestone
1.26.0
Development

No branches or pull requests
2 participants
@raphj @Josue-T