Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kv client #6

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

LingKa28
Copy link
Contributor

@LingKa28 LingKa28 commented Dec 4, 2023

Base on #2

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add KV clinet

  • what changes does this pull request make?

    • add kv client
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (42e35cd) 79.24% compared to head (92420d0) 93.97%.

Files Patch % Lines
client/kv.py 90.16% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
+ Coverage   79.24%   93.97%   +14.73%     
===========================================
  Files           4        8        +4     
  Lines         159      382      +223     
  Branches       20       23        +3     
===========================================
+ Hits          126      359      +233     
+ Misses         24       16        -8     
+ Partials        9        7        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: LingKa <[email protected]>
client/protocol.py Outdated Show resolved Hide resolved
client/txn.py Show resolved Hide resolved
@LingKa28 LingKa28 merged commit ea76964 into xline-kv:main Dec 5, 2023
8 checks passed
@LingKa28 LingKa28 mentioned this pull request Dec 6, 2023
@LingKa28 LingKa28 deleted the feature/kv-client branch December 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants