-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auth client #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 93.97% 91.28% -2.70%
==========================================
Files 8 10 +2
Lines 382 608 +226
Branches 23 32 +9
==========================================
+ Hits 359 555 +196
- Misses 16 39 +23
- Partials 7 14 +7 ☔ View full report in Codecov by Sentry. |
LingKa28
force-pushed
the
feature/auth-client
branch
2 times, most recently
from
December 5, 2023 14:45
83e2397
to
98dd259
Compare
bsbds
reviewed
Dec 6, 2023
rogercloud
reviewed
Dec 6, 2023
LingKa28
force-pushed
the
feature/auth-client
branch
2 times, most recently
from
December 7, 2023 04:33
384d826
to
69067bb
Compare
bsbds
reviewed
Dec 7, 2023
Signed-off-by: LingKa <[email protected]>
Merged
LingKa28
force-pushed
the
feature/auth-client
branch
from
December 7, 2023 08:56
69067bb
to
0143ebf
Compare
bsbds
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #2
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add new feature.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No.