Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auth client #5

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

LingKa28
Copy link
Contributor

@LingKa28 LingKa28 commented Nov 9, 2023

Base on #2

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add new feature.

  • what changes does this pull request make?

    • add auth client.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

@LingKa28 LingKa28 marked this pull request as draft November 9, 2023 05:35
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (ea76964) 93.97% compared to head (0143ebf) 91.28%.

Files Patch % Lines
client/auth.py 77.86% 23 Missing and 6 partials ⚠️
tests/auth_test.py 98.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   93.97%   91.28%   -2.70%     
==========================================
  Files           8       10       +2     
  Lines         382      608     +226     
  Branches       23       32       +9     
==========================================
+ Hits          359      555     +196     
- Misses         16       39      +23     
- Partials        7       14       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LingKa28 LingKa28 force-pushed the feature/auth-client branch 2 times, most recently from 83e2397 to 98dd259 Compare December 5, 2023 14:45
@LingKa28 LingKa28 marked this pull request as ready for review December 5, 2023 14:46
@xline-kv xline-kv deleted a comment from mergify bot Dec 6, 2023
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/auth.py Outdated Show resolved Hide resolved
client/client.py Show resolved Hide resolved
tests/auth_test.py Show resolved Hide resolved
@LingKa28 LingKa28 force-pushed the feature/auth-client branch 2 times, most recently from 384d826 to 69067bb Compare December 7, 2023 04:33
client/auth.py Outdated Show resolved Hide resolved
client/client.py Show resolved Hide resolved
@LingKa28 LingKa28 merged commit cf2e30a into xline-kv:main Dec 7, 2023
6 of 8 checks passed
@LingKa28 LingKa28 changed the title feature: auth client feat: auth client Dec 9, 2023
@LingKa28 LingKa28 deleted the feature/auth-client branch December 9, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants