ci: add bench ci for pr #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 75.55% 75.50% -0.05%
==========================================
Files 180 186 +6
Lines 26938 27488 +550
Branches 26938 27488 +550
==========================================
+ Hits 20353 20756 +403
- Misses 5366 5459 +93
- Partials 1219 1273 +54 ☔ View full report in Codecov by Sentry. |
iGxnon
added
run-benchmark
iGxnon
added
run-benchmark
iGxnon
force-pushed
the
bench-ci
branch
2 times, most recently
from
eb73608
to
a91ff88
Compare
iGxnon
force-pushed
the
bench-ci
branch
4 times, most recently
from
cf13f23
to
210a119
Compare
|
@iGxnon Your PR is in conflict and cannot be merged. |
|
@iGxnon You've modified the workflows. Please don't forget to update the .mergify.yml. |
rogercloud
reviewed
Apr 20, 2024
scripts/benchmark.sh
Outdated
| @@ -127,7 +131,7 @@ stop_all() { | |||
| for name in "node1" "node2" "node3" "client"; do | |||
| docker_id=$(docker ps -qf "name=${name}") | |||
| if [ -n "$docker_id" ]; then | |||
| docker stop $docker_id | |||
| docker stop $docker_id -t 1 | |||
There was a problem hiding this comment.
Why do you wait 1 second before killing the container?
| cat out_local/xline.txt >> bench_outputs | ||
| echo "\`\`\`" >> bench_outputs | ||
|
|
||
| # echo -e "\r\n### Base \r\n\`\`\`txt" >> bench_outputs |
There was a problem hiding this comment.
Do these commentted lines required after 0.7.0?
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iGxnon [email protected]
Example: iGxnon#2
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add benchmark CI for each PR which labeled
run-benchmarkwhat changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No