-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix xline member add bug #658
Conversation
e408889
to
66a8e80
Compare
25259a8
to
4d95846
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 75.55% 75.60% +0.04%
==========================================
Files 180 186 +6
Lines 26938 27488 +550
Branches 26938 27488 +550
==========================================
+ Hits 20353 20782 +429
- Misses 5366 5431 +65
- Partials 1219 1275 +56 ☔ View full report in Codecov by Sentry. |
4d95846
to
cd5efbc
Compare
@Phoenix500526 Your PR is in conflict and cannot be merged. |
cd5efbc
to
d0039d8
Compare
@Phoenix500526 Convert your pr to draft since CI failed |
aa044d1
to
2bc9e02
Compare
@Phoenix500526 Convert your pr to draft since CI failed |
83f51a5
to
d36db93
Compare
d36db93
to
1b1fec4
Compare
@Phoenix500526 Your PR is in conflict and cannot be merged. |
1b1fec4
to
6857139
Compare
@Phoenix500526 Your PR is in conflict and cannot be merged. |
6857139
to
e58be20
Compare
Closes: xline-kv#661 Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
e58be20
to
2c9504c
Compare
Please briefly answer these questions:
cluster_validation
test case to cover the whole member add process.self_peer_urls
to match themember.peer_urls
and add client URLs