Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix xline member add bug #658

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

Phoenix500526
Copy link
Collaborator

@Phoenix500526 Phoenix500526 commented Feb 22, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
  1. close issue [Bug]: Failed to add a new member node4 to a three-nodes xline cluster #661
  • what changes does this pull request make?
  1. enrich the cluster_validation test case to cover the whole member add process.
  2. sort the self_peer_urls to match the member.peer_urls and add client URLs
  3. add a single node cluster mode flag to specify a special case —— scale out from one node cluster to a two nodes clsuter.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 force-pushed the fix/scale-out branch 3 times, most recently from e408889 to 66a8e80 Compare February 25, 2024 01:44
@xline-kv xline-kv deleted a comment from codecov bot Feb 25, 2024
@xline-kv xline-kv deleted a comment from codecov bot Feb 25, 2024
@xline-kv xline-kv deleted a comment from codecov bot Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.60%. Comparing base (e35b35a) to head (2c9504c).
Report is 92 commits behind head on master.

Files Patch % Lines
crates/curp/src/members.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   75.55%   75.60%   +0.04%     
==========================================
  Files         180      186       +6     
  Lines       26938    27488     +550     
  Branches    26938    27488     +550     
==========================================
+ Hits        20353    20782     +429     
- Misses       5366     5431      +65     
- Partials     1219     1275      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

mergify bot commented Apr 18, 2024

@Phoenix500526 Your PR is in conflict and cannot be merged.

@mergify mergify bot requested a review from a team April 19, 2024 04:35
scripts/validation_test.sh Show resolved Hide resolved
scripts/validation_test.sh Outdated Show resolved Hide resolved
scripts/common.sh Show resolved Hide resolved
crates/curp/src/members.rs Outdated Show resolved Hide resolved
Copy link

mergify bot commented May 11, 2024

@Phoenix500526 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft May 11, 2024 02:25
@mergify mergify bot added the CI:fail CI has failed label May 11, 2024
@Phoenix500526 Phoenix500526 force-pushed the fix/scale-out branch 2 times, most recently from aa044d1 to 2bc9e02 Compare May 11, 2024 02:27
@mergify mergify bot marked this pull request as ready for review May 11, 2024 02:40
@mergify mergify bot removed the CI:fail CI has failed label May 11, 2024
Copy link

mergify bot commented May 11, 2024

@Phoenix500526 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft May 11, 2024 05:34
@mergify mergify bot added the CI:fail CI has failed label May 11, 2024
@mergify mergify bot marked this pull request as ready for review May 11, 2024 06:16
@mergify mergify bot removed the CI:fail CI has failed label May 11, 2024
@Phoenix500526 Phoenix500526 linked an issue May 13, 2024 that may be closed by this pull request
1 task
Copy link

mergify bot commented May 13, 2024

@Phoenix500526 Your PR is in conflict and cannot be merged.

rogercloud
rogercloud previously approved these changes May 18, 2024
@mergify mergify bot requested a review from a team May 18, 2024 13:15
Copy link

mergify bot commented May 20, 2024

@Phoenix500526 Your PR is in conflict and cannot be merged.

rogercloud
rogercloud previously approved these changes May 20, 2024
@mergify mergify bot requested a review from a team May 20, 2024 02:32
crates/curp/src/members.rs Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 21, 2024 07:35
@mergify mergify bot requested a review from a team May 22, 2024 06:46
@mergify mergify bot merged commit 500f280 into xline-kv:master May 22, 2024
14 checks passed
@mergify mergify bot requested a review from a team May 22, 2024 07:56
@Phoenix500526 Phoenix500526 deleted the fix/scale-out branch August 26, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to add a new member node4 to a three-nodes xline cluster
3 participants