Port 'Location' demo to Python #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About the Vala issue: Can you open an issue in the main Workbench repo about this? I'm pretty sure your assumption is correct. |
theCapypara
requested changes
Feb 20, 2024
|
@rolandlo is this ready for re-review? Don't forget to hit the button
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the Javascript demo except for using
GLib.DateTimefor getting and formatting the timestamp. That is also done in the Vala implementation and I think Javascript should also use it rather than a Javascript only Date object.The demo seems to work, although I have to say the accuracy is very low (sometimes the location is off by around 90 km) and the altitude I get (from WIFI data) is worth nothing (it seems to be the smallest float that can be represented, something like -1.7*10^308). It's the same with the Javascript implementation.
The Vala demo doesn't run on my system, since it can't find
libportal/portal.h. I would have assumed that having the Vala extension installed should be enough to get all Vala demos running.