Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vala Location demo can't find libportal/portal.h. #885

Closed
rolandlo opened this issue Feb 15, 2024 · 2 comments · Fixed by #886
Closed

Vala Location demo can't find libportal/portal.h. #885

rolandlo opened this issue Feb 15, 2024 · 2 comments · Fixed by #886
Labels
vala

Comments

@rolandlo
Copy link
Contributor

The Vala Location demo doesn't run on my system, since it can't find libportal/portal.h. I would assume that having the Vala extension installed should be enough to get all Vala demos running.

This was observed when porting the demo to Python in workbenchdev/demos#89
@rolandlo rolandlo added the vala label Feb 15, 2024
@sonnyp
Copy link
Contributor

sonnyp commented Feb 16, 2024

@Diego-Ivan wanna look into that?

@Diego-Ivan
Copy link
Contributor

@sonnyp Sure, I'll take a look at it

@Diego-Ivan Diego-Ivan mentioned this issue Feb 17, 2024
Merged
sonnyp pushed a commit that referenced this issue Feb 18, 2024
@Diego-Ivan
flatpak: Remove /app/include from cleanup (#886)
259a61c 
Before this change, Workbench installed via Flatpak was not able to run
Vala demos that required Shumate, Libportal or Libspelling because their
header files were removed by the cleanup process. The versions of
Workbench that are run from Builder or flatpak-vscode can actually
compile and execute this demos because they don't do any clean-up, and
therefore none of the header files are deleted, which is probably why
this issue went unnoticed for quite some time even when porting the
affected demos to Vala.

In order to test this changes and compare them with the current version
of Workbench, it is necessary to export a bundle and install it, so the
cleanup process is actually done.

Closes #885
Hofer-Julian pushed a commit that referenced this issue Mar 24, 2024
@Diego-Ivan @Hofer-Julian
flatpak: Remove /app/include from cleanup (#886)
1d7fdad 
Before this change, Workbench installed via Flatpak was not able to run
Vala demos that required Shumate, Libportal or Libspelling because their
header files were removed by the cleanup process. The versions of
Workbench that are run from Builder or flatpak-vscode can actually
compile and execute this demos because they don't do any clean-up, and
therefore none of the header files are deleted, which is probably why
this issue went unnoticed for quite some time even when porting the
affected demos to Vala.

In order to test this changes and compare them with the current version
of Workbench, it is necessary to export a bundle and install it, so the
cleanup process is actually done.

Closes #885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vala
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flatpak: Remove /app/include from cleanup workbenchdev/Workbench
3 participants
@sonnyp @rolandlo @Diego-Ivan