Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: process.stdout regression #6933

Merged
merged 5 commits into from
Jul 22, 2024
Merged

fix: process.stdout regression #6933

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51365a5
fix: process.stdout regression
Chriscbr Jul 22, 2024
824b70b
add test
Chriscbr Jul 22, 2024
ab5a84f
Merge branch 'main' into rybickic/fix-logs
monadabot Jul 22, 2024
1e59e13
chore: self mutation (e2e-1of2.diff)
monadabot Jul 22, 2024
74308a7
Revert "chore: self mutation (e2e-1of2.diff)"
Chriscbr Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/wingcompiler/src/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export function determineTargetFromPlatforms(platforms: string[]): string {
*/
export async function compile(entrypoint: string, options: CompileOptions): Promise<string> {
const { log } = options;
const preflightLog = options.preflightLog ?? console.log;
const preflightLog = options.preflightLog ?? process.stdout.write.bind(process.stdout);
Chriscbr marked this conversation as resolved.
Show resolved Hide resolved
// create a unique temporary directory for the compilation
const targetdir = options.targetDir ?? join(dirname(entrypoint), "target");
const entrypointFile = resolve(entrypoint);
Expand Down Expand Up @@ -211,7 +211,7 @@ export async function compile(entrypoint: string, options: CompileOptions): Prom
await runPreflightCodeInWorkerThread(
compileForPreflightResult.preflightEntrypoint,
preflightEnv,
(data) => preflightLog?.(data.toString().trim())
(data) => preflightLog?.(data.toString())
);
}
return synthDir;
Expand Down
Loading