Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process.stdout regression #6933

Merged
merged 5 commits into from
Jul 22, 2024
Merged

fix: process.stdout regression #6933

merged 5 commits into from
Jul 22, 2024

Conversation

Chriscbr
Copy link
Contributor

Fixes #6928

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner July 22, 2024 19:51
@Chriscbr Chriscbr requested a review from skyrpex July 22, 2024 19:51
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Jul 22, 2024

Console preview environment is available at https://wing-console-pr-6933.fly.dev 🚀

Last Updated (UTC) 2024-07-22 20:47

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.35 60ms±1.38 +3ms (+5.32%)🟥
empty.test.w -t sim 385ms±21.18 383ms±14.51 -2ms (-0.55%)⬜
empty.test.w -t tf-aws 627ms±4.41 624ms±4.39 -3ms (-0.52%)⬜
hello_world.test.w -t sim 409ms±7.45 415ms±4.19 +5ms (+1.31%)⬜
hello_world.test.w -t tf-aws 1486ms±9.01 1540ms±14.5 +53ms (+3.6%)🟥
jsii_big.test.w -t sim 2948ms±19.02 3036ms±18.77 +88ms (+2.98%)⬜
jsii_big.test.w -t tf-aws 3141ms±17.27 3207ms±19.55 +66ms (+2.09%)⬜
functions_1.test.w -t sim 400ms±4.23 406ms±3.53 +5ms (+1.32%)⬜
functions_1.test.w -t tf-aws 856ms±6.06 868ms±17.17 +12ms (+1.42%)⬜
functions_10.test.w -t sim 509ms±4.85 496ms±22.44 -13ms (-2.58%)⬜
functions_10.test.w -t tf-aws 2182ms±13.69 2188ms±24.99 +6ms (+0.28%)⬜
jsii_small.test.w -t sim 377ms±3.02 378ms±2.73 +0ms (+0.1%)⬜
jsii_small.test.w -t tf-aws 620ms±7.25 631ms±8.05 +11ms (+1.77%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 58ms 64ms 1ms 2ms
empty.test.w -t sim 383ms 369ms 437ms 15ms 20ms
empty.test.w -t tf-aws 624ms 614ms 634ms 4ms 6ms
hello_world.test.w -t sim 415ms 407ms 429ms 4ms 6ms
hello_world.test.w -t tf-aws 1540ms 1518ms 1587ms 15ms 20ms
jsii_big.test.w -t sim 3036ms 3006ms 3077ms 19ms 26ms
jsii_big.test.w -t tf-aws 3207ms 3167ms 3247ms 20ms 27ms
functions_1.test.w -t sim 406ms 399ms 412ms 4ms 5ms
functions_1.test.w -t tf-aws 868ms 843ms 924ms 17ms 24ms
functions_10.test.w -t sim 496ms 445ms 540ms 22ms 31ms
functions_10.test.w -t tf-aws 2188ms 2123ms 2237ms 25ms 35ms
jsii_small.test.w -t sim 378ms 373ms 384ms 3ms 4ms
jsii_small.test.w -t tf-aws 631ms 609ms 652ms 8ms 11ms
Last Updated (UTC) 2024-07-22 20:01

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jul 22, 2024
@monadabot
Copy link
Contributor

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (1e59e13) for suspicious changes.
This is typically caused by:

  • Absolute paths
  • Timestamps
  • Random values
  • Flakey tests (relying on one of the above)

@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jul 22, 2024
Copy link
Contributor

mergify bot commented Jul 22, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/fix-logs is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 6e7c631 into main Jul 22, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/fix-logs branch July 22, 2024 20:57
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.79.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output via JavaScript integration broken in Wing 0.77.16
4 participants