fix(compiler): unable to lift @inflight args without struct expansion

[MarkMcCulloh]

Fixes #6922

Ideally we'll have something like @lift and won't need to special-case this, but in the meantime...

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

[github-actions]

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic	Owner
Wing SDK and utility APIs	@chriscbr
Wing Console	@ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections	@hasanaburayyan
Platforms and plugins	@hasanaburayyan
Frontend resources (website, react, etc)	@tsuf239
Language design	@chriscbr
VSCode extension and language server	@markmcculloh
Compiler architecture, inflights, lifting	@yoav-steinberg
Wing Testing Framework	@tsuf239
Wing CLI	@markmcculloh
Build system, dev environment, releases	@markmcculloh
Library Ecosystem	@chriscbr
Documentation	@hasanaburayyan
SDK test suite	@tsuf239
Examples	@hasanaburayyan
Wing Playground	@eladcon

[monadabot]

Console preview environment is available at https://wing-console-pr-6925.fly.dev 🚀

Last Updated (UTC) 2024-07-23 10:54

[mergify]

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/fix-inflight-lifts is up-to-date with main and the queue is empty.

[monadabot]

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥🟥⬜⬜

Benchmark	Before	After	Change
version	61ms±0.86	56ms±0.64	-4ms (-7.17%)⬜
functions_10.test.w -t sim	531ms±11.85	504ms±23.31	-27ms (-5.14%)⬜
functions_10.test.w -t tf-aws	2273ms±21.08	2234ms±21.22	-39ms (-1.71%)⬜
jsii_small.test.w -t sim	388ms±4.4	380ms±4.35	-9ms (-2.21%)⬜
jsii_small.test.w -t tf-aws	645ms±7.49	620ms±3.41	-25ms (-3.84%)⬜
jsii_big.test.w -t sim	2998ms±24.35	2961ms±13.11	-37ms (-1.25%)⬜
jsii_big.test.w -t tf-aws	3210ms±13.02	3194ms±14.52	-16ms (-0.5%)⬜
hello_world.test.w -t sim	416ms±6.18	411ms±4.95	-5ms (-1.12%)⬜
hello_world.test.w -t tf-aws	1507ms±5.57	1498ms±7.2	-9ms (-0.58%)⬜
empty.test.w -t sim	370ms±4.09	382ms±7.73	+11ms (+3.06%)🟥
empty.test.w -t tf-aws	610ms±3.93	641ms±6.23	+31ms (+5.1%)🟥
functions_1.test.w -t sim	405ms±4.11	417ms±4.83	+12ms (+2.91%)⬜
functions_1.test.w -t tf-aws	859ms±5.65	864ms±6.58	+6ms (+0.66%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results

name	mean	min	max	moe	sd
version	56ms	56ms	58ms	1ms	1ms
functions_10.test.w -t sim	504ms	461ms	578ms	23ms	33ms
functions_10.test.w -t tf-aws	2234ms	2194ms	2306ms	21ms	30ms
jsii_small.test.w -t sim	380ms	370ms	386ms	4ms	6ms
jsii_small.test.w -t tf-aws	620ms	612ms	629ms	3ms	5ms
jsii_big.test.w -t sim	2961ms	2933ms	2988ms	13ms	18ms
jsii_big.test.w -t tf-aws	3194ms	3166ms	3229ms	15ms	20ms
hello_world.test.w -t sim	411ms	403ms	423ms	5ms	7ms
hello_world.test.w -t tf-aws	1498ms	1480ms	1517ms	7ms	10ms
empty.test.w -t sim	382ms	365ms	394ms	8ms	11ms
empty.test.w -t tf-aws	641ms	630ms	658ms	6ms	9ms
functions_1.test.w -t sim	417ms	407ms	427ms	5ms	7ms
functions_1.test.w -t tf-aws	864ms	853ms	883ms	7ms	9ms

Last Updated (UTC) 2024-07-22 17:48

[skyrpex]

I'll check out the unstable mutation tomorrow (related to the simulator lockfile).

[skyrpex]

Sorry about that. The problem with the lockfile lies in the async nature of its implementation: the lock(), updateLockfileLater() and release() methods are all async, and in some cases the release happens during the lockfile updating mechanism.

I'll prepare a separate PR to fix that, and test it with your changes here just in case.

[monadabot]

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (f3fcc72) for suspicious changes.
This is typically caused by:

• Absolute paths
• Timestamps
• Random values
• Flakey tests (relying on one of the above)

[mergify]

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/fix-inflight-lifts is up-to-date with main and the queue is empty.

[monadabot]

Congrats! 🚀 This was released in Wing 0.79.7.