Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): improved wing debugging and docs (breakpoints) #5981
feat(vscode): improved wing debugging and docs (breakpoints) #5981
Changes from 2 commits
fcfd5ec
58c4f28
62a8b5d
d1b9c7f
1d0b44c
dfd86da
5f605bc
9da72be
d5d46d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason to quote inflight every time. It's a term we use, not a symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use
inflight
over "inflight" pretty often because it's a keyword. I would do the same withlet
orclass
. Should inflight specifically not use "`" or should other keywords also not get backticks?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use backticks when we refer to the keyword and no backticks when we refer to the concept or the term.
For example:
"Let's declare a class that represents an employee."
"To declare a data shape use the
struct
keyword followed by the name of the struct""This value is a constant"
Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, the keyword is the concept and vice-versa. It helps my brain establish the link between the two, so that when I see the
word
in code I'll think of the concept and when I read theword
in docs I'll think about how it's used in code.I don't get confused when I see alternating
struct
vs "struct" so always usingbackticks
isn't crazy important to me, but I'm not sold on the reasoning to avoid them so far.The only reason I do get is aesthetics, because
keywords
can be pretty ugly when overused. So if that's part of our "Style Guide" then ok.