-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): improved wing debugging and docs (breakpoints) #5981
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-5981.fly.dev 🚀 Last Updated (UTC) 2024-03-19 02:49 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-03-19 02:54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yey!
docs/docs/06-tools/03-debugging.md
Outdated
|
||
### Limitations | ||
|
||
- When using the Wing Console (`wing it`) and attempting to debug `inflight` code in a `test` or Function, the first execution of the test will not hit a breakpoint and will need to be run again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When using the Wing Console (`wing it`) and attempting to debug `inflight` code in a `test` or Function, the first execution of the test will not hit a breakpoint and will need to be run again | |
- When using the Wing Console (`wing it`) and attempting to debug inflight code in a `test` or Function, the first execution of the test will not hit a breakpoint and will need to be run again |
I don't see a reason to quote inflight every time. It's a term we use, not a symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use inflight
over "inflight" pretty often because it's a keyword. I would do the same with let
or class
. Should inflight specifically not use "`" or should other keywords also not get backticks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use backticks when we refer to the keyword and no backticks when we refer to the concept or the term.
For example:
-
"Let's declare a class that represents an employee."
-
"To declare a data shape use the
struct
keyword followed by the name of the struct" -
"This value is a constant"
Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, the keyword is the concept and vice-versa. It helps my brain establish the link between the two, so that when I see the word
in code I'll think of the concept and when I read the word
in docs I'll think about how it's used in code.
I don't get confused when I see alternating struct
vs "struct" so always using backticks
isn't crazy important to me, but I'm not sold on the reasoning to avoid them so far.
The only reason I do get is aesthetics, because keywords
can be pretty ugly when overused. So if that's part of our "Style Guide" then ok.
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.61.16. |
To support this, a change was made to the simulator to bundle inflights next to the entrypoint. This helps VSCode (and other debugger probably) to discover the file that's running.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.