Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(cli): introduce default entrypoints #4408

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

Broke windows

Reverts #4257

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner October 4, 2023 13:25
@MarkMcCulloh MarkMcCulloh merged commit d9e096e into main Oct 4, 2023
11 checks passed
@MarkMcCulloh MarkMcCulloh deleted the revert-4257-garysassano/cli-default-entrypoints branch October 4, 2023 13:28
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.18.

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 108ms±5.15 110ms±6.27 +2ms (+1.68%)⬜
functions_10.test.w -t sim 913ms±12.78 917ms±17.81 +3ms (+0.34%)⬜
functions_10.test.w -t tf-aws 5458ms±38.45 5472ms±45.61 +14ms (+0.25%)⬜
jsii_big.test.w -t sim 5360ms±72.69 5325ms±125.79 -35ms (-0.66%)⬜
jsii_big.test.w -t tf-aws 5376ms±44.64 5538ms±47.01 +162ms (+3.01%)🟥
hello_world.test.w -t sim 791ms±8.65 807ms±14.27 +16ms (+2.03%)⬜
hello_world.test.w -t tf-aws 6544ms±68.02 6651ms±61.37 +107ms (+1.63%)⬜
empty.test.w -t sim 741ms±14.27 747ms±11.71 +6ms (+0.83%)⬜
empty.test.w -t tf-aws 947ms±17.03 956ms±14.5 +9ms (+0.98%)⬜
jsii_small.test.w -t sim 759ms±12.48 753ms±9.34 -6ms (-0.84%)⬜
jsii_small.test.w -t tf-aws 954ms±12.13 950ms±13.26 -3ms (-0.36%)⬜
functions_1.test.w -t sim 829ms±12.08 851ms±16.5 +22ms (+2.65%)⬜
functions_1.test.w -t tf-aws 2932ms±86.52 2904ms±36.49 -27ms (-0.94%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 110ms 100ms 131ms 6ms 9ms
functions_10.test.w -t sim 917ms 894ms 963ms 18ms 25ms
functions_10.test.w -t tf-aws 5472ms 5361ms 5598ms 46ms 64ms
jsii_big.test.w -t sim 5325ms 5125ms 5618ms 126ms 176ms
jsii_big.test.w -t tf-aws 5538ms 5483ms 5686ms 47ms 66ms
hello_world.test.w -t sim 807ms 771ms 837ms 14ms 20ms
hello_world.test.w -t tf-aws 6651ms 6539ms 6801ms 61ms 86ms
empty.test.w -t sim 747ms 721ms 768ms 12ms 16ms
empty.test.w -t tf-aws 956ms 931ms 989ms 15ms 20ms
jsii_small.test.w -t sim 753ms 742ms 770ms 9ms 13ms
jsii_small.test.w -t tf-aws 950ms 932ms 977ms 13ms 19ms
functions_1.test.w -t sim 851ms 821ms 894ms 17ms 23ms
functions_1.test.w -t tf-aws 2904ms 2832ms 2995ms 36ms 51ms
Last Updated (UTC) 2023-10-04 13:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants