Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): default entrypoints #4412

Merged
merged 52 commits into from
Oct 9, 2023
Merged

Conversation

garysassano
Copy link
Collaborator

@garysassano garysassano commented Oct 4, 2023

This is a continuation of #4257

New version got fixed to work also on Windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

garysassano and others added 30 commits September 22, 2023 01:39
Co-authored-by: Mark McCulloh <[email protected]>
Co-authored-by: Mark McCulloh <[email protected]>
@garysassano garysassano force-pushed the garysassano/cli-default-entrypoints branch from da75150 to 23adadf Compare October 4, 2023 15:07
@garysassano garysassano force-pushed the garysassano/cli-default-entrypoints branch from a9f8fa7 to 2be2e12 Compare October 4, 2023 15:14
@monadabot
Copy link
Contributor

monadabot commented Oct 4, 2023

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 86ms±3.11 88ms±3.89 +3ms (+2.98%)⬜
functions_10.test.w -t sim 775ms±10 810ms±11.04 +35ms (+4.54%)🟥
functions_10.test.w -t tf-aws 4645ms±38.66 4669ms±30.46 +24ms (+0.52%)⬜
jsii_big.test.w -t sim 4435ms±32.73 4517ms±49.14 +82ms (+1.85%)⬜
jsii_big.test.w -t tf-aws 4583ms±50.41 4615ms±29.97 +32ms (+0.7%)⬜
hello_world.test.w -t sim 701ms±11.72 714ms±15.81 +13ms (+1.88%)⬜
hello_world.test.w -t tf-aws 5522ms±34.77 5574ms±38.47 +51ms (+0.93%)⬜
empty.test.w -t sim 652ms±15.61 666ms±10.98 +14ms (+2.11%)⬜
empty.test.w -t tf-aws 818ms±8.89 835ms±8.3 +17ms (+2.04%)⬜
jsii_small.test.w -t sim 653ms±13.29 674ms±10.04 +22ms (+3.32%)⬜
jsii_small.test.w -t tf-aws 817ms±9.89 847ms±15.86 +30ms (+3.72%)⬜
functions_1.test.w -t sim 728ms±18.32 764ms±21.18 +37ms (+5.06%)⬜
functions_1.test.w -t tf-aws 2529ms±99.37 2569ms±90.79 +40ms (+1.57%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 88ms 85ms 100ms 4ms 5ms
functions_10.test.w -t sim 810ms 777ms 827ms 11ms 15ms
functions_10.test.w -t tf-aws 4669ms 4616ms 4752ms 30ms 43ms
jsii_big.test.w -t sim 4517ms 4427ms 4638ms 49ms 69ms
jsii_big.test.w -t tf-aws 4615ms 4500ms 4672ms 30ms 42ms
hello_world.test.w -t sim 714ms 680ms 766ms 16ms 22ms
hello_world.test.w -t tf-aws 5574ms 5459ms 5643ms 38ms 54ms
empty.test.w -t sim 666ms 648ms 688ms 11ms 15ms
empty.test.w -t tf-aws 835ms 825ms 851ms 8ms 12ms
jsii_small.test.w -t sim 674ms 659ms 702ms 10ms 14ms
jsii_small.test.w -t tf-aws 847ms 829ms 903ms 16ms 22ms
functions_1.test.w -t sim 764ms 731ms 833ms 21ms 30ms
functions_1.test.w -t tf-aws 2569ms 2404ms 2770ms 91ms 127ms
Last Updated (UTC) 2023-10-09 21:43

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 4, 2023
@garysassano garysassano force-pushed the garysassano/cli-default-entrypoints branch from f51b64b to 1ce5b95 Compare October 4, 2023 21:58
@eladb eladb changed the title feat(cli): introduce default entrypoints new feat(cli): default entrypoints Oct 6, 2023
apps/wing/src/commands/compile.ts Outdated Show resolved Hide resolved
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/cli-default-entrypoints is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit ab0803c into main Oct 9, 2023
23 checks passed
@mergify mergify bot deleted the garysassano/cli-default-entrypoints branch October 9, 2023 23:13
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.36.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants