Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): ambiguous api paths are allowed #4352

Merged
merged 30 commits into from
Oct 4, 2023
Merged

fix(sdk): ambiguous api paths are allowed #4352

merged 30 commits into from
Oct 4, 2023

Conversation

gcfbn
Copy link
Contributor

@gcfbn gcfbn commented Oct 1, 2023

Fixes the issue #4052 by adding a check if newly added path is ambiguous with paths already added to the API. I've re-created the #4291 PR, as it got stuck on merging main to the feature branch.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@gcfbn gcfbn requested a review from a team as a code owner October 1, 2023 11:41
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 1, 2023
@tsuf239
Copy link
Collaborator

tsuf239 commented Oct 1, 2023

the tests pass on aws!
image
I'll approve as soon as we can fix the test snapshot (let me know if any help is needed), canceling the build for now

gcfbn and others added 18 commits October 1, 2023 20:11
@gcfbn
Try with <DURATION>
825217c
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
6982b26
@monadabot
chore: self mutation (e2e-2of2.diff)
3a3dc93 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
840a1e3
@monadabot
chore: self mutation (e2e-2of2.diff)
af24a96 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
9cf300e
@monadabot
chore: self mutation (e2e-2of2.diff)
66d4c51 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
592c611
@monadabot
chore: self mutation (e2e-2of2.diff)
36ce728 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
4e8a8bf
@monadabot
chore: self mutation (e2e-2of2.diff)
5756770 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
08ad6ba
@monadabot
chore: self mutation (e2e-2of2.diff)
f0bf69d 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
2faecc7
@monadabot
chore: self mutation (e2e-2of2.diff)
4a27a30 
Signed-off-by: monada-bot[bot] <[email protected]>
@gcfbn
Revert "Try with <DURATION>"
62b9e6e 
This reverts commit 825217c.
@monadabot
Merge branch 'main' into 4052-ambiguous-api-paths
ac15230
@monadabot
chore: self mutation (e2e-2of2.diff)
3b483ce 
Signed-off-by: monada-bot[bot] <[email protected]>
@tsuf239
Copy link
Collaborator

tsuf239 commented Oct 2, 2023

Another option I can suggest is to comment out the invalid test code and I'll open an issue and fix it at our end :)

@gcfbn
Copy link
Contributor Author

gcfbn commented Oct 2, 2023

Another option I can suggest is to comment out the invalid test code and I'll open an issue and fix it at our end :)

Alright, if you're fine with this approach, it works for me too.

@gcfbn
Copy link
Contributor Author

gcfbn commented Oct 2, 2023 •
edited
Loading

@tsuf239 Apparently it won't work for a file without any tests

@tsuf239
Copy link
Collaborator

tsuf239 commented Oct 3, 2023

I see, so it's ok to remove this file, I'll add it back in a new PR with the path serialization fixed

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

Thanks for contributing, @gcfbn! This PR will now be added to the merge queue, or immediately merged if 4052-ambiguous-api-paths is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 4, 2023
@mergify
Merge of #4352
da52de4
@mergify mergify bot mentioned this pull request Oct 4, 2023
Closed
14 tasks
@mergify mergify bot merged commit 4d4420c into winglang:main Oct 4, 2023
15 checks passed
@tsuf239 tsuf239 mentioned this pull request Oct 4, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this pull request Oct 4, 2023
@tsuf239
chore: add ambiguous paths invalid tests and sanitize output (#4404)
53e042a 
leftover from this task: #4352

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.16.

@gcfbn gcfbn deleted the 4052-ambiguous-api-paths branch October 4, 2023 11:33
@tsuf239 tsuf239 mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuf239 tsuf239 tsuf239 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcfbn @tsuf239 @monadabot