Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (0e8e85f) and #4352 together #4402

Closed
wants to merge 31 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 4, 2023

🎉 This pull request has been checked successfully and will be merged. 🎉

Branch main (0e8e85f) and #4352 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4352.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

Required conditions to stay in the queue:

Visit the Mergify Dashboard to check the state of the queue default.


More information about Mergify merge queue can be found in the documentation.

Mergify commands

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the queue rules

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

---
pull_requests:
  - number: 4352
...

gcfbn and others added 30 commits October 1, 2023 13:36
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 86ms±2.96 86ms±2.25 +0ms (+0.54%)⬜
functions_10.test.w -t sim 748ms±11.67 756ms±17.5 +8ms (+1.01%)⬜
functions_10.test.w -t tf-aws 4612ms±55.43 4597ms±45.03 -15ms (-0.33%)⬜
jsii_big.test.w -t sim 4273ms±22.02 4311ms±28.26 +38ms (+0.88%)⬜
jsii_big.test.w -t tf-aws 4418ms±44.79 4417ms±44.56 -1ms (-0.02%)⬜
hello_world.test.w -t sim 660ms±7.83 663ms±18.56 +2ms (+0.36%)⬜
hello_world.test.w -t tf-aws 5465ms±38.83 5448ms±30.02 -17ms (-0.31%)⬜
empty.test.w -t sim 612ms±11.5 615ms±10.78 +2ms (+0.4%)⬜
empty.test.w -t tf-aws 780ms±9.16 766ms±9.66 -14ms (-1.81%)⬜
jsii_small.test.w -t sim 619ms±7.26 619ms±15.34 +0ms (+0.07%)⬜
jsii_small.test.w -t tf-aws 795ms±11.32 782ms±16.13 -13ms (-1.61%)⬜
functions_1.test.w -t sim 697ms±15.64 697ms±13.86 0ms (-0.01%)⬜
functions_1.test.w -t tf-aws 2481ms±71.03 2441ms±114.83 -40ms (-1.6%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 86ms 82ms 88ms 2ms 3ms
functions_10.test.w -t sim 756ms 731ms 805ms 18ms 24ms
functions_10.test.w -t tf-aws 4597ms 4422ms 4712ms 45ms 63ms
jsii_big.test.w -t sim 4311ms 4244ms 4375ms 28ms 40ms
jsii_big.test.w -t tf-aws 4417ms 4330ms 4505ms 45ms 62ms
hello_world.test.w -t sim 663ms 640ms 731ms 19ms 26ms
hello_world.test.w -t tf-aws 5448ms 5385ms 5500ms 30ms 42ms
empty.test.w -t sim 615ms 599ms 649ms 11ms 15ms
empty.test.w -t tf-aws 766ms 741ms 788ms 10ms 14ms
jsii_small.test.w -t sim 619ms 594ms 677ms 15ms 21ms
jsii_small.test.w -t tf-aws 782ms 764ms 838ms 16ms 23ms
functions_1.test.w -t sim 697ms 684ms 745ms 14ms 19ms
functions_1.test.w -t tf-aws 2441ms 2216ms 2784ms 115ms 161ms
Last Updated (UTC) 2023-10-04 09:01

@mergify mergify bot closed this Oct 4, 2023
@mergify mergify bot deleted the mergify/merge-queue/2932b8f952 branch October 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants