-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): set log retention for cloud.Function (tf-aws and awscdk) #4303
Conversation
6028483
to
d43c997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible add a wing test? (is there a way maybe an HTTP call to verify this property was set?)
also, when I think of it now, maybe it will be good to add a "global" log retention value (let's say I want to set any of my resources to 1 week retention period), which probably should be in a different PR |
@tsuf239 Rebased into the main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @exoego! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.34.14. |
Part of #4134
Added
logRetentionDays
property tocloud.Function
.It is implemented for tf-aws and awscdk.
I skipped tf-gcp and tf-azure since the ticket does not mention and other cloud provider appears to have default retention:
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.