Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (6b0b357) and #4303 together #4388

Closed
wants to merge 4 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 3, 2023

🎉 This pull request has been checked successfully and will be merged. 🎉

Branch main (6b0b357) and #4303 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4303.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

Required conditions to stay in the queue:

Visit the Mergify Dashboard to check the state of the queue default.


More information about Mergify merge queue can be found in the documentation.

Mergify commands

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the queue rules

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

---
pull_requests:
  - number: 4303
...

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 87ms±2.7 95ms±4.93 +8ms (+9.37%)⬜
functions_10.test.w -t sim 773ms±9.41 791ms±10.28 +18ms (+2.26%)⬜
functions_10.test.w -t tf-aws 4834ms±32.77 4799ms±38.69 -36ms (-0.74%)⬜
jsii_big.test.w -t sim 4537ms±44.67 4493ms±23.74 -43ms (-0.96%)⬜
jsii_big.test.w -t tf-aws 4622ms±37.5 4658ms±38.83 +36ms (+0.78%)⬜
hello_world.test.w -t sim 675ms±8.02 674ms±7.92 -1ms (-0.15%)⬜
hello_world.test.w -t tf-aws 5679ms±37.5 5706ms±44.67 +28ms (+0.49%)⬜
empty.test.w -t sim 628ms±7.6 636ms±8.41 +8ms (+1.23%)⬜
empty.test.w -t tf-aws 813ms±8.76 807ms±8 -6ms (-0.8%)⬜
jsii_small.test.w -t sim 635ms±7.73 626ms±6.71 -10ms (-1.55%)⬜
jsii_small.test.w -t tf-aws 812ms±11 799ms±10.54 -13ms (-1.64%)⬜
functions_1.test.w -t sim 710ms±8.53 713ms±7.56 +3ms (+0.41%)⬜
functions_1.test.w -t tf-aws 2653ms±67.37 2576ms±100.85 -77ms (-2.9%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 95ms 89ms 111ms 5ms 7ms
functions_10.test.w -t sim 791ms 770ms 814ms 10ms 14ms
functions_10.test.w -t tf-aws 4799ms 4728ms 4918ms 39ms 54ms
jsii_big.test.w -t sim 4493ms 4410ms 4529ms 24ms 33ms
jsii_big.test.w -t tf-aws 4658ms 4586ms 4735ms 39ms 54ms
hello_world.test.w -t sim 674ms 654ms 687ms 8ms 11ms
hello_world.test.w -t tf-aws 5706ms 5560ms 5823ms 45ms 62ms
empty.test.w -t sim 636ms 623ms 651ms 8ms 12ms
empty.test.w -t tf-aws 807ms 798ms 817ms 8ms 11ms
jsii_small.test.w -t sim 626ms 619ms 632ms 7ms 9ms
jsii_small.test.w -t tf-aws 799ms 775ms 820ms 11ms 15ms
functions_1.test.w -t sim 713ms 703ms 725ms 8ms 11ms
functions_1.test.w -t tf-aws 2576ms 2330ms 2780ms 101ms 141ms
Last Updated (UTC) 2023-10-03 11:08

@mergify mergify bot closed this Oct 3, 2023
@mergify mergify bot deleted the mergify/merge-queue/6ed508267e branch October 3, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants