Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MediaWiki core hooks #33

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Conversation

Derugon
Copy link
Collaborator

@Derugon Derugon commented Jan 11, 2024

Add definitions and basic documentation for the hooks used in MediaWiki core, as mentioned in #26.

Hook names have been retrieved from a source code search, so there may be some missing, I do not know if there is a full list somewhere.

Notes (on things I'm not sure about):

  • Both apisandbox.formatRequest and wikipage.diff.diffTypeSwitch hooks reference OOUI objects, so it is added as a dependency.
  • User data from mw.user is used in the postEdit hook, so it has been moved into a separate User class.

Adrien LESÉNÉCHAL added 3 commits January 9, 2024 09:00
@Derugon Derugon marked this pull request as draft January 11, 2024 10:48
@Derugon Derugon marked this pull request as ready for review January 11, 2024 11:27
@@ -23,15 +23,16 @@
},
"homepage": "https://github.com/wikimedia-gadgets/types-mediawiki#readme",
"dependencies": {
"@types/jquery": "^3.5.5"
"@types/jquery": "^3.5.5",
"@types/oojs-ui": "^0.46.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this create a circular dependency issue? I would assume @types/oojs-ui itself depends on this package. cc @diskdance @ChlodAlejandro

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this and this, they do not depend on this package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I guess let's do this then

@siddharthvp siddharthvp merged commit 773af71 into wikimedia-gadgets:main Jan 19, 2024
1 check passed
AnYiEE added a commit to AnYiEE/types-mediawiki-renovate that referenced this pull request Jan 19, 2024
AnYiEE added a commit to AnYiEE/types-mediawiki-renovate that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants