Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for OOjs & OOUI? #12

Closed
diskdance opened this issue Jun 16, 2022 · 6 comments
Closed

Types for OOjs & OOUI? #12

diskdance opened this issue Jun 16, 2022 · 6 comments

Comments

@diskdance
Copy link
Contributor

diskdance commented Jun 16, 2022

Hi.

Gadgets interacting with users make use of OOUI and OOjs a lot, it would be nice if their types are added here. Are there any plans towards this? Thank you.

@hsl0
Copy link
Contributor

hsl0 commented Nov 13, 2022

There are types for OOjs in npm from DefinitelyTyped. (@types/oojs) However, unfortunately, there aren't for OOUI.

@diskdance
Copy link
Contributor Author

diskdance commented Dec 20, 2022

Types for OOUI are waiting for review at DefinitelyTyped/DefinitelyTyped#63675.

EDIT: It has been published on npm at @types/oojs-ui.

@diskdance
Copy link
Contributor Author

diskdance commented Dec 29, 2022

We can probably include @types/oojs and @types/oojs-ui as dependencies, but before this there is another problem that currently I am the only owner of these two packages, meaning every PR to them is required to be reviewed by myself. This is a single point of failure so I hope someone else is willing to become additional owners, thanks.

@siddharthvp
Copy link
Member

@diskdance thanks for publishing the types for oojs/ui. However, I don't think this library should specify them as dependencies as OOUI is not used in the core JS interface which this library represents (as is the case with jQuery), and also as OOUI is on its way out and most user scripts and gadgets today are not using it anyway. I think they're better kept as separate libraries - much like @types/jqueryui which is also not a dependency. But feel free to include a note about them in this repo's README!

@diskdance
Copy link
Contributor Author

Mentioned in #20.

@siddharthvp
Copy link
Member

Update: they were eventually added as dependencies, via #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants