Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: new static homepage using vue template #760

Merged
merged 10 commits into from
Sep 12, 2024
Merged

docs: new static homepage using vue template #760

merged 10 commits into from
Sep 12, 2024

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented Aug 29, 2024 •
edited
Loading

Implements the new static homepage using a Vue template.

ToDo:

  • Replace last .png files with .svgs Edit: blocked because of a figma issue.
  • Animated assets (Lottie?) Edit: see above
  • Extra pages (roadmap, pricing, etc)?
  • homepage CSS doesn't load in early enough Edit: should be fixed by SSG

@render Render
Copy link

render bot commented Aug 29, 2024

Your Render PR Server URL is https://solara-stable-pr-760.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cr85dpaj1k6c73a911cg.

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Aug 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch 2 times, most recently from 2b01f57 to e34dfe2 Compare September 4, 2024 10:51
This was referenced Sep 4, 2024
Merged
Merged
@iisakkirotko iisakkirotko force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch 2 times, most recently from 40430f6 to ccd72b9 Compare September 6, 2024 07:44
@iisakkirotko iisakkirotko force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch from ccd72b9 to 24db2f0 Compare September 6, 2024 08:03
@iisakkirotko iisakkirotko marked this pull request as ready for review September 6, 2024 08:59
@maartenbreddels maartenbreddels temporarily deployed to 08-29-docs_new_static_homepage_using_vue_template - solara-stable PR #760 September 9, 2024 14:00 — with Render Destroyed
@iisakkirotko iisakkirotko force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch from 68de778 to 8aed59d Compare September 9, 2024 14:07
maartenbreddels
maartenbreddels reviewed Sep 11, 2024
View reviewed changes
solara/website/components/contact.py
},
data=json.dumps(msg),
)
print("Email sent successfully!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that our linting does not catch this, it used to not allow this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, indeed.

maartenbreddels
maartenbreddels reviewed Sep 11, 2024
View reviewed changes
solara/website/components/contact.py
message = solara.use_reactive("")
error: solara.Reactive[Optional[str]] = solara.use_reactive(None)

def send(*_ignore):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would have done this with a task, and also do the error handling with that. Ok to keep it as it is for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice the operation taking any time, so I didn't even come to think of using task. It would probably be a more robust implementation, so maybe we can implement it later

@maartenbreddels maartenbreddels force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch from 97e21c6 to 7a6b7a9 Compare September 11, 2024 14:11
@maartenbreddels maartenbreddels force-pushed the 08-29-docs_new_static_homepage_using_vue_template branch from 7a6b7a9 to 12b6729 Compare September 11, 2024 15:34
@maartenbreddels maartenbreddels temporarily deployed to 08-29-docs_new_static_homepage_using_vue_template - solara-stable PR #760 September 11, 2024 15:34 — with Render Destroyed
@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Sep 12, 2024 •
edited
Loading

Merge activity

@iisakkirotko iisakkirotko merged commit d718e4f into master Sep 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels