Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: usability improvements to docs search #770

Merged
merged 1 commit into from
Sep 12, 2024
Merged

docs: usability improvements to docs search #770

merged 1 commit into from
Sep 12, 2024

Conversation

iisakkirotko
Copy link
Collaborator

  • fixes a bug where the results box would show that a negative number more results exist
  • Keyboard navigation for results

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Sep 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from b31be0f to 01c6d47 Compare September 4, 2024 15:19
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from 49d7a04 to 54eba5d Compare September 4, 2024 15:19
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 01c6d47 to ae05356 Compare September 5, 2024 15:53
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch 2 times, most recently from 8bffe38 to 5d39083 Compare September 6, 2024 07:31
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 41e2421 to 4c93cc6 Compare September 6, 2024 07:44
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from 5d39083 to f8ab649 Compare September 6, 2024 07:44
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 4c93cc6 to 05f0185 Compare September 6, 2024 08:03
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from f8ab649 to c3ef3a0 Compare September 6, 2024 08:04
@iisakkirotko iisakkirotko marked this pull request as ready for review September 6, 2024 09:04
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 05f0185 to 7b0c364 Compare September 9, 2024 14:00
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from c3ef3a0 to d2d128d Compare September 9, 2024 14:00
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 7b0c364 to 4039f1c Compare September 9, 2024 14:07
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from d2d128d to 0a9d880 Compare September 9, 2024 14:07
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 4039f1c to 1fb63e4 Compare September 9, 2024 15:00
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from 0a9d880 to c27b61e Compare September 9, 2024 15:00
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 1fb63e4 to 41883b7 Compare September 10, 2024 14:57
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from c27b61e to 2a2e079 Compare September 10, 2024 14:57
@maartenbreddels maartenbreddels force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 41883b7 to 86b1809 Compare September 11, 2024 14:11
@maartenbreddels maartenbreddels force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from 2a2e079 to cb26add Compare September 11, 2024 14:13
@maartenbreddels maartenbreddels force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 86b1809 to 945258f Compare September 11, 2024 15:34
@maartenbreddels maartenbreddels force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from cb26add to da4a614 Compare September 11, 2024 15:34
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_new_look_for_documentation_pages branch from 945258f to 04ec1d0 Compare September 12, 2024 08:38
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from da4a614 to d902f94 Compare September 12, 2024 08:38
@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Sep 12, 2024 •
edited
Loading

Merge activity

  • Sep 12, 6:57 AM EDT: @iisakkirotko started a stack merge that includes this pull request via Graphite.
  • Sep 12, 7:03 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 7:04 AM EDT: @iisakkirotko merged this pull request with Graphite.

@iisakkirotko iisakkirotko mentioned this pull request Sep 12, 2024
Merged
@iisakkirotko iisakkirotko changed the base branch from 09-04-docs_new_look_for_documentation_pages to graphite-base/770 September 12, 2024 10:59
@iisakkirotko iisakkirotko changed the base branch from graphite-base/770 to master September 12, 2024 11:01
@iisakkirotko
docs: usability improvements to docs search
d3f402a 
- fixes a bug where the results box would show that a negative number more results exist
- Keyboard navigation for results
@iisakkirotko iisakkirotko force-pushed the 09-04-docs_usability_improvements_to_docs_search branch from d902f94 to d3f402a Compare September 12, 2024 11:02
@maartenbreddels maartenbreddels temporarily deployed to 09-04-docs_usability_improvements_to_docs_search - solara-stable PR #770 September 12, 2024 11:02 — with Render Destroyed
@iisakkirotko iisakkirotko merged commit aa871a3 into master Sep 12, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels