test: make test more robust by non using globals and guessing the context #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
maartenbreddels
changed the base branch from
10-03-feat_allow_reconnecting_to_existing_kernel_and_display_widget_by_id
to
10-03-refactor_use_kernel_id_instead_of_session_id
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
2 times, most recently
from
8184556
to
8eb41fa
Compare
maartenbreddels
force-pushed
the
10-03-refactor_use_kernel_id_instead_of_session_id
branch
from
1c7acd5
to
8358105
Compare
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
8eb41fa
to
dcac72f
Compare
maartenbreddels
force-pushed
the
10-03-refactor_use_kernel_id_instead_of_session_id
branch
from
8358105
to
ac85fa2
Compare
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
dcac72f
to
5897f28
Compare
Closed
maartenbreddels
force-pushed
the
10-03-refactor_use_kernel_id_instead_of_session_id
branch
from
ac85fa2
to
b1f21e8
Compare
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
5897f28
to
dc2cd38
Compare
maartenbreddels
force-pushed
the
10-03-refactor_use_kernel_id_instead_of_session_id
branch
from
b1f21e8
to
f660bf9
Compare
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
dc2cd38
to
7b0d651
Compare
maartenbreddels
force-pushed
the
10-03-refactor_use_kernel_id_instead_of_session_id
branch
from
f660bf9
to
062b154
Compare
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
7b0d651
to
d78eac8
Compare
maartenbreddels
changed the base branch from
10-03-refactor_use_kernel_id_instead_of_session_id
to
master
…text We relied on a global variable to wait for the component to be called, but this seems to not be very robust. Instead, we pass a unique ID via a query parameter to not re-use the Event object, and store the context that we actually use, instead of relying on the last used context found.
maartenbreddels
force-pushed
the
10-05-test_make_test_more_robust_by_non_using_globals_and_guessing_the_context
branch
from
d78eac8
to
3af1276
Compare
Merge Activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We relied on a global variable to wait for the component to be called,
but this seems to not be very robust. Instead, we pass a unique ID
via a query parameter to not re-use the Event object, and store the
context that we actually use, instead of relying on the last used
context found.