fix: make solara_test fixture not fail subsequent tests #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 4, 2023
maartenbreddels
changed the base branch from
10-03-refactor_use_kernel_id_instead_of_session_id
to
10-04-fix_baseUrl_should_not_be_suffixed_with_/jupyter
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
from
401ad53
to
1a55570
Compare
maartenbreddels
force-pushed
the
10-04-fix_baseUrl_should_not_be_suffixed_with_/jupyter
branch
from
1c1478f
to
9691007
Compare
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
from
1a55570
to
6b2d0f1
Compare
maartenbreddels
changed the base branch from
10-04-fix_baseUrl_should_not_be_suffixed_with_/jupyter
to
10-05-fix_pass_search_query_directly_to_solara
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
from
6b2d0f1
to
57f160d
Compare
This was referenced Oct 5, 2023
maartenbreddels
changed the base branch from
10-05-fix_pass_search_query_directly_to_solara
to
master
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
2 times, most recently
from
9803f2c
to
800f751
Compare
Closed
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
from
800f751
to
058c039
Compare
If the test failed once, it will fail all subsequent tests because it did not do a proper cleanup.
maartenbreddels
force-pushed
the
10-04-fix_make_solara_test_fixture_not_fail_subsequent_tests
branch
from
058c039
to
63d16c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test failed once, it will fail all subsequent tests because
it did not do a proper cleanup.