Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass settings to the jinja template. #303

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: pass settings to the jinja template. #303

merged 1 commit into from
Sep 27, 2023

Commits on Sep 27, 2023

  1. fix: pass settings to the jinja template. 

    Because we did not implement a setter for the settings, command
line arguments were not passed to the jinja template.
Values were set, but .dict() used the _values dict which was
not updated by the setter.

Note that environment variables did work, so although
SOLARA_THEME_VARIANT=dark HOST=localhost solara run ...
Did work, the following did not:
HOST=localhost solara run ... --theme-variant=dark
    @maartenbreddels
    maartenbreddels committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e37405a View commit details
    Browse the repository at this point in the history