fix: pass settings to the jinja template. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #296 |
Because we did not implement a setter for the settings, command line arguments were not passed to the jinja template. Values were set, but .dict() used the _values dict which was not updated by the setter. Note that environment variables did work, so although SOLARA_THEME_VARIANT=dark HOST=localhost solara run ... Did work, the following did not: HOST=localhost solara run ... --theme-variant=dark
maartenbreddels
force-pushed
the
fix_settings
branch
from
0e83a38
to
e37405a
Compare
iisakkirotko
pushed a commit
to iisakkirotko/solara
that referenced
this pull request
Sep 29, 2023
Because we did not implement a setter for the settings, command line arguments were not passed to the jinja template. Values were set, but .dict() used the _values dict which was not updated by the setter. Note that environment variables did work, so although SOLARA_THEME_VARIANT=dark HOST=localhost solara run ... Did work, the following did not: HOST=localhost solara run ... --theme-variant=dark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we did not implement a setter for the settings, command
line arguments were not passed to the jinja template.
Values were set, but .dict() used the _values dict which was
not updated by the setter.
Note that environment variables did work, so although
SOLARA_THEME_VARIANT=dark HOST=localhost solara run ...
Did work, the following did not:
HOST=localhost solara run ... --theme-variant=dark